Re: [PATCH 2/9] x86 idle: remove NOP cpuinfo_x86.hlt_works_ok flag

From: Alan Cox
Date: Thu Mar 31 2011 - 05:26:31 EST


> Do we know whether a distro adds this to the boot line? Do we know about users
> relying on it.

I certainly had hardware that needed it. Don't any more but this is more
trying to rip out stuff without letting nature take its course.

It's a trivial feature item.

> > Do we really need both?
>
> Probably not, as i said i do not disagree - i just think it should be more
> explicit. Make it a: "users of CPU models X beware" commit title, not 'remove
> inactive code' ...

Just make the one config variable respond to both boot configuration
options. The parser is __init code anyway so discarded so the actual code
cost of compatibility is exactly NIL.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/