Re: [PATCH 05/12] mm: alloc_contig_range() added

[Dave Hansen]

On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote:
> +       ret = 0;
> +       while (!PageBuddy(pfn_to_page(start & (~0UL << ret))))
> +               if (WARN_ON(++ret >= MAX_ORDER))
> +                       return -EINVAL; 

Holy cow, that's dense.  Is there really no more straightforward way to
do that?

In any case, please pull the ++ret bit out of the WARN_ON().  Some
people like to do:

#define WARN_ON(...) do{}while(0)

to save space on some systems.  

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/