Re: [BUG] libmount misparses mountinfo on Linux v2.6.39-rc1

From: Miklos Szeredi
Date: Fri Apr 01 2011 - 04:46:20 EST


On Fri, 01 Apr 2011, Aneesh Kumar K. V wrote:
> On Thu, 31 Mar 2011 22:24:01 +0200, victor.vde@xxxxxxxxx wrote:
> > /proc/self/mountinfo on Linux v2.6.39-rc1 includes the UUID of ext4
> > and ext3 mounts, for example:
> >
> > 15 1 8:3 / / rw,noatime uuid:c645234d-9756-4d84-825e-6fe999252a34 - ext4 /dev/sda3 rw,user_xattr,acl,barrier=1,data=ordered
> >
> > It seems the hyphens in the uuid confuse the parser
> > mnt_parse_mountinfo_line in tab_parse.c of libmount in util-linux.
>
> shouldn't the parser look for " " followed by "-" followed by " " as the
> field seperator ?
>
> I am adding Miklos and Ram Pai to CC to check whether the kernel or the libmount
> should be fixed ?

I think libmount should be fixed, though there is always the question
of backward compatibility.

However I don't see how the kernel could be fixed, given that libmount
doesn't seem to parse escape sequences (e.g. "\040" for space), which
it also should.

Karel?

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/