Re: [PATCH 0/3] Unmapped page cache control (v5)

From: KOSAKI Motohiro
Date: Sun Apr 03 2011 - 05:39:38 EST


> > > > Hm. OK, I may misread.
> > > > Can you please explain the reason why de-duplication feature need to selectable and
> > > > disabled by defaut. "explicity enable" mean this feature want to spot corner case issue??
> > >
> > > Yes, because given a selection of choices (including what you
> > > mentioned in the review), it would be nice to have
> > > this selectable.
> >
> > It's no good answer. :-/
>
> I am afraid I cannot please you with my answers
>
> > Who need the feature and who shouldn't use it? It this enough valuable for enough large
> > people? That's my question point.
> >
>
> You can see the use cases documented, including when running Linux as
> a guest under other hypervisors,

Which hypervisor? If this patch is unrelated 99.9999% people, shouldn't you have to reduce
negative impact?


> today we have a choice of not using
> host page cache with cache=none, but nothing the other way round.
> There are other use cases for embedded folks (in terms of controlling
> unmapped page cache), please see previous discussions.

Is there other usecase? really? Where exist?
Why do you start to talk about embedded sudenly? I reviewed this as virtualization feature
beucase you wrote so in [path 0/3]. Why do you change your point suddenly?




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/