Re: [PATCH] uio/pdrv_genirq: Add OF support

From: Wolfram Sang
Date: Mon Apr 04 2011 - 13:32:07 EST


Hi Hans,

> > If the generic driver is not sufficent for a user and he
> > patches it, he can simply patch the version string, too?
>
> Or better write a dedicated driver. Patching a generic thing like uio_pdrv_genirq
> can only be done in specialized drivers in a project. That's hackery that won't
> make it into mainline anyway.

I exactly meant that, maybe didn't make it clear enough. Of course, a seperate
driver would be better, but guess what will happen in most projects.

> > Or can we use the notifiers to set up an individual version? That could also be
> > the place to do special board-setup connected to the selected version.
>
> How could that look like? If you have an idea for a generic solution, you're
> welcome.

That was more a brainstorming question; there are notifiers which help
populating function-pointers which also can't be expressed in a device-tree.
I just wanted to make sure this approach doesn't get overlooked.

So, the solution for now is to simply add a default value and we can check
later if it can be modified at runtime?

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature