Re: [PATCH 0/4] mmc_spi: Add support for regulator framework

From: Grant Likely
Date: Mon Apr 04 2011 - 23:06:06 EST


On Mon, Apr 04, 2011 at 11:56:31AM +0200, Antonio Ospite wrote:
> On Mon, 21 Mar 2011 19:46:38 +0100
> Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote:
>
> > Hi,
> >
> > this patchset has the purpose of adding support for the regulator framework to
> > the mmc_spi driver. The first three patches are preparatory cleanups to make
> > the fourth one more straightforward.
> >
> > Maybe the fourth patch can be improved, I am open to any suggestions about it.
> >
>
> Ping. I forgot to Cc spi-devel-general on this series, should I resend
> it?

Not a bad idea. It doesn't go via my tree since it is an mmc patch,
not an spi one, but I don't mind taking a look at the spi bits.

g.

>
> > These changes take strong inspiration from the pxamci driver; they have been
> > tested on a Motorola A910, which uses a regulator to powerup the MMC card
> > connected to the SPI bus, a test from a current user of the mmc_spi driver
> > would not hurt just to be sure no regressions have been introduced.
> >
> > Thanks,
> > Antonio
> >
> > Antonio Ospite (4):
> > mmc_spi.c: factor out the check for power capability
> > mmc_spi.c: factor out the SD card shutdown sequence
> > mmc_spi.c: factor out a mmc_spi_setpower() function
> > mmc_spi.c: add support for the regulator framework
> >
> > drivers/mmc/host/mmc_spi.c | 194 +++++++++++++++++++++++++++++---------------
> > 1 files changed, 129 insertions(+), 65 deletions(-)
> >
>
> --
> Antonio Ospite
> http://ao2.it
>
> PGP public key ID: 0x4553B001
>
> A: Because it messes up the order in which people normally read text.
> See http://en.wikipedia.org/wiki/Posting_style
> Q: Why is top-posting such a bad thing?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/