Re: [PATCH 7/8] Documentation: consolidate leds files to leds/subdir
From: Antonio Ospite
Date: Tue Apr 05 2011 - 04:26:52 EST
On Mon, 4 Apr 2011 17:54:04 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Apr 4, 2011 at 3:08 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> > Changes since v1:
> > - don't use git renames
> Actually, I think it would make it much easier to validate the patches
> if you used git rename patches for things like this.
I agree, and I did that for the first review round.
Initially the patch was meant to be handled by Andrew Morton, maybe I
misunderstood one of his comments from
"hm, these look like funky git renames. patch(1) doesn't
and though he wanted me to change that.
> As a traditional patch, it's impossible to see that "yes, it's a
> rename". There might be tons of changes hiding in the add/remove pair.
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
Description: PGP signature