Re: [PATCH] HID: Add NOGET quirk for the CH Pro Throttle

From: Unavowed
Date: Tue Apr 05 2011 - 11:33:45 EST


On 04/04/11 12:41, Jiri Kosina wrote:
> On Mon, 4 Apr 2011, Unavowed wrote:
>
>>>> The CH Pro Throttle needs the NOGET quirk flag to work, just like other CH
>>>> Products devices which already have the flag set.
>>>>
>>>> Signed-off-by: Unavowed <unavowed@xxxxxxxxxxxxx>
>>>
>>> Hi,
>>>
>>> thanks a lot for the patch.
>>>
>>> Would it please be possible to have a real name to attribute for patch
>>> authorship and Signed-off-by line?
>>
>> Hi,
>>
>> Thanks for such a quick response.
>>
>> I'm sorry, but I only ever write contributions under a pseudonym. Is
>> this not acceptable, especially for such a trivial patch?
>
> Well, see paragraph 12) of Documentation/SubmittingPatches. Especially the
> part with "sorry, no pseudonyms or anonymous contributions".
>
> Now, I agree that trivial USB ID addition such as this really is
> a bit borderline ...

If that's the case then I would like to report a bug. The HID device:

068e:00f1 CH Products, Inc. Pro Throttle

doesn't work with Linux. After plugging in the device, it is recognised
but pressing buttons or moving axes doesn't trigger any events. Adding
an entry to the HID blacklist with the HID_QUIRK_NOGET flag fixes the
problem.

I, and probably other flight sim fans running Linux, would be very happy
if someone could fix write a patch fixing this.

And if I may comment on that "no pseudonyms" policy, I don't fully
understand the motivation behind it. After all, there have been many
authors of copyrighted works who created them without revealing their
real name[1]. Is this something to please the lawyers of Linux's
corporate overlords?

Thanks,

Unavowed

[1] http://en.wikipedia.org/wiki/List_of_pseudonyms
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/