Re: [PATCH] leds: provide helper to register "leds-gpio" devices

From: Fabio Estevam
Date: Tue Apr 05 2011 - 12:28:52 EST


Hi Uwe,

On 4/5/2011 5:37 AM, Uwe Kleine-KÃnig wrote:
> This function makes a deep copy of the platform data to allow it to live
> in init memory.
> The definition cannot go into leds-gpio.c because it needs to be builtin
> to be usable by platforms.
>
> Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>

I tested your patch on a MX53EVK board, but I could only build it after unselecting the mmc driver.

This is the error I got when mmc was selected:

CC drivers/mmc/card/mmc_test.o
LD drivers/mmc/card/built-in.o
CC drivers/mmc/core/sdio_io.o
In file included from include/linux/mmc/host.h:13,
from drivers/mmc/core/sdio_io.c:12:
include/linux/leds.h:220: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gpio_led_register_device'
make[3]: *** [drivers/mmc/core/sdio_io.o] Error 1
make[2]: *** [drivers/mmc/core] Error 2
make[1]: *** [drivers/mmc] Error 2
make: *** [drivers] Error 2

Regards,

Fabio Estevam


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/