Re: [PATCH 01/14] x86-32, NUMA: Fix failure condition check in alloc_remap()

From: Yinghai Lu
Date: Tue Apr 05 2011 - 13:21:18 EST


On 04/04/2011 03:23 PM, Tejun Heo wrote:
node_remap_{start|end}_vaddr[] describe [start, end) ranges; however,
alloc_remap() incorrectly failed when the current allocation + size
equaled the end but it should fail only when it goes over. Fix it.

Signed-off-by: Tejun Heo<tj@xxxxxxxxxx>
Cc: Yinghai Lu<yinghai@xxxxxxxxxx>
Cc: David Rientjes<rientjes@xxxxxxxxxx>
Cc: Thomas Gleixner<tglx@xxxxxxxxxxxxx
Cc: Ingo Molnar<mingo@xxxxxxxxxx>
Cc: "H. Peter Anvin"<hpa@xxxxxxxxx>
---
arch/x86/mm/numa_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c
index bde3906..84aac47 100644
--- a/arch/x86/mm/numa_32.c
+++ b/arch/x86/mm/numa_32.c
@@ -200,7 +200,7 @@ void *alloc_remap(int nid, unsigned long size)

size = ALIGN(size, L1_CACHE_BYTES);

- if (!allocation || (allocation + size)>= node_remap_end_vaddr[nid])
+ if (!allocation || (allocation + size)> node_remap_end_vaddr[nid])
return NULL;

node_remap_alloc_vaddr[nid] += size;

Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/