RE: [PATCH 1/1] uio: clean uioinfo when uninstall uio driver

[Dong Aisheng-B29396]

> -----Original Message-----
> From: Hans J. Koch [mailto:hjk@xxxxxxxxxxxx]
> Sent: Tuesday, April 05, 2011 1:16 AM
> To: Dong Aisheng-B29396
> Cc: hjk@xxxxxxxxxxxx; greg@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/1] uio: clean uioinfo when uninstall uio driver
> 
> On Sat, Apr 02, 2011 at 04:55:23PM +0800, Aisheng Dong wrote:
> > From: Jie Zhou <b30303@xxxxxxxxxxxxx>
> >
> > The uioinfo should be cleaned up when uninstall, otherwise re-install
> > failure of uio_pdrv_genirq.ko will happen.
> >
> > Signed-off-by: Jie Zhou <b30303@xxxxxxxxxxxxx>
> > Signed-off-by: Aisheng Dong <b29396@xxxxxxxxxxxxx>
> > ---
> >  drivers/uio/uio_pdrv_genirq.c |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/uio/uio_pdrv_genirq.c
> > b/drivers/uio/uio_pdrv_genirq.c index 7174d51..e669a2c 100644
> > --- a/drivers/uio/uio_pdrv_genirq.c
> > +++ b/drivers/uio/uio_pdrv_genirq.c
> > @@ -189,6 +189,12 @@ static int uio_pdrv_genirq_remove(struct
> > platform_device *pdev)
> >
> >  	uio_unregister_device(priv->uioinfo);
> >  	pm_runtime_disable(&pdev->dev);
> > +
> > +	priv->uioinfo->irq_flags = 0;
> 
> Why this one?
Could be removed.

> > +	priv->uioinfo->handler = NULL;
> > +	priv->uioinfo->irqcontrol = NULL;
> 
> Both OK, good catch!
> 
> > +	priv->uioinfo->priv = NULL;
> 
> Why this one?
Could be removed.

Thanks for the info.
The V2 patch will be soon.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/