Re: [PATCH 5/5] driver core: let dev_set_drvdata return int insteadof void as it can fail

From: Michał Mirosław
Date: Wed Apr 06 2011 - 05:37:14 EST

2011/4/6 Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>:
> Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Hello,
> I wasn't sure what to return when dev_set_drvdata is called with
> dev=NULL. ÂI choosed 0, but -EINVAL would be OK for me, too. What do you
> think?

Why not just BUG_ON(!dev)? Is there a case when you might call this
with dev==NULL that's not a driver bug?

Best Regards,
MichaÅ MirosÅaw
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at