Re: [RFC PATCH 3/7] basic_mmio_gpio: allow overriding number ofgpio

From: Anton Vorontsov
Date: Wed Apr 06 2011 - 08:18:18 EST


On Wed, Apr 06, 2011 at 12:10:59PM +0100, Jamie Iles wrote:
[...]
> + if (pdata) {
> + bgc->gc.base = pdata->base;
> + if (pdata->ngpio > 0)
> + ngpio = pdata->ngpio;
> + } else
> + bgc->gc.base = -1;

Just a minor comstic nit: 'else' case should be with braces as well.
I.e. '} else {'.

But techincally, the patch looks perfect,

Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>

Thanks,

--
Anton Vorontsov
Email: cbouatmailru@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/