Re: [PATCH] HID: Add NOGET quirk for the CH Pro Throttle

From: Jiri Kosina
Date: Wed Apr 06 2011 - 10:17:37 EST


On Tue, 5 Apr 2011, Unavowed wrote:

> >> I'm sorry, but I only ever write contributions under a pseudonym. Is
> >> this not acceptable, especially for such a trivial patch?
> >
> > Well, see paragraph 12) of Documentation/SubmittingPatches. Especially the
> > part with "sorry, no pseudonyms or anonymous contributions".
> >
> > Now, I agree that trivial USB ID addition such as this really is
> > a bit borderline ...
>
> If that's the case then I would like to report a bug. The HID device:
>
> 068e:00f1 CH Products, Inc. Pro Throttle
>
> doesn't work with Linux. After plugging in the device, it is recognised
> but pressing buttons or moving axes doesn't trigger any events. Adding
> an entry to the HID blacklist with the HID_QUIRK_NOGET flag fixes the
> problem.
>
> I, and probably other flight sim fans running Linux, would be very happy
> if someone could fix write a patch fixing this.

I thought you'd figure that out :) Thanks for the report, I have queued
the fix in my tree.

> And if I may comment on that "no pseudonyms" policy, I don't fully
> understand the motivation behind it. After all, there have been many
> authors of copyrighted works who created them without revealing their
> real name[1]. Is this something to please the lawyers of Linux's
> corporate overlords?

I guess this would be topic for a separate thread, but anyway ... but I
believe you'd be able to dig much information from reading the threads
where entity calling itself 'Shem Multinymous' tried to submit Thinkpad
Embedded Controller drivers.

It basically defeats the Developer's Certificate of Origin process
completely.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/