Re: [PATCH 0/2] ARM: Unify setup for Marvell SheevaPlugs and SeagateDockStars

[Alexander Holler]

Am 07.04.2011 00:50, schrieb Nico Erfurth:
> Alexander Holler wrote:
>
> > The first patch merges the setup for Seagate DockStars into the setup
> > for Marvell SheevaPlugs and the second one removes the machine type for
> > DockStars at all.
>
> That looks fine so far.
>
> > Removing the machine type for DockStar shouldn't be a big problem. Support
> > for them is already broken in mainline U-Boot since 2 versions, so changing the
> > stuff there is already needed and it shouldn't be a problem to use the same
> > machine type as used for SheevaPlugs there.
>
> This sounds like very bad reasoning to me. The Dockstar has a machine-id
> assigned, if the bootloader is broken, people should either use a
> working version, or fix the current one.
>
> Also, using the memory-size to differ between these two machines sounds
> like something thats doomed to fail in the future.

I wonder how many people believe that either there will be another 
DockStar with the same HW and GPIOs for the LEDs but more memory (and 
still without sata) or that there will be another SheevaPlug with just 
128MB RAM or that someone could have a reason to change the memory 
layout using a mem= parameter.

For me all that is pretty unlikely.

Anyway, if someone wants, he could just use my patch 1/2 and replace 
patch 2/2 with a patch which changes the one line which checks the 
memory layout to be one bank with 128MB to machine_is_dockstar().

Regards,

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/