[PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak inlme_firmware_switch()

From: Jesper Juhl
Date: Thu Apr 07 2011 - 15:46:14 EST


Don't leak 'fw' in
drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to
call release_firmware().

Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
---
lmedm04.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

compile tested only

diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c
index cd26e7c..d7cc625 100644
--- a/drivers/media/dvb/dvb-usb/lmedm04.c
+++ b/drivers/media/dvb/dvb-usb/lmedm04.c
@@ -799,7 +799,7 @@ static int lme_firmware_switch(struct usb_device *udev, int cold)
if (cold) {
info("FRM Changing to %s firmware", fw_lme);
lme_coldreset(udev);
- return -ENODEV;
+ ret = -ENODEV;
}

release_firmware(fw);


--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/