Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver

From: RafaÅ MiÅecki
Date: Fri Apr 08 2011 - 15:46:28 EST


2011/4/8 Joe Perches <joe@xxxxxxxxxxx>:
> On Fri, 2011-04-08 at 21:45 +0200, RafaÅ MiÅecki wrote:
>> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h
> []
>> +#define axi_info   pr_info
>> +#ifdef CONFIG_AXI_DEBUG
>> +#define axi_debug  Âpr_debug
>> +#else
>> +#define axi_debug  Âdo { } while (0)
>> +#endif
>> +#define axi_err       Âpr_err
>
> I think redefining standard functionality like
> this doesn't gain anything and loses some basic
> grep capability.

But on the other hand using:
pr_info, pr_err, BUT axi_debug
can easily lead to mistakes.

Or is this possible to re-define pr_debug locally?

--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/