Re: [PATCH] ux500: Adding support for u8500 Hsem functionality.

[Ohad Ben-Cohen]

Hi Mathieu,

On Fri, Apr 8, 2011 at 11:28 PM,  <mathieu.poirier@xxxxxxxxxx> wrote:
...

> + * Author: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> + * Heavily borrowed from the work of :
> + *   Simon Que <sque@xxxxxx>
> + *   Hddari Kanigeri <h-kanigeri2@xxxxxx>

s/Hddari/Hari/

> +       platform_set_drvdata(pdev, state);
> +
> +       /* no pm needed for HSem but required to comply
> +        * with hwspilock core.
> +        */
> +       pm_runtime_enable(&pdev->dev);

You seem to have removed the calls to pm_runtime_disable() throughout
the driver, is that on purpose ?

You should see an "Unbalanced pm_runtime_enable!" warning about this
if you tried rmmod'ing and insmod'ing the driver again.

And just a minor comment if you're submitting a v2: you have a bunch
of trailing whitespaces; try checkpatch to spot them easily.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/