Re: [PATCH] HV SynthHID: Fix compile error.

From: Andrei Warkentin
Date: Mon Apr 11 2011 - 16:14:39 EST


On Mon, Apr 11, 2011 at 2:27 PM, Greg KH <gregkh@xxxxxxx> wrote:
> On Mon, Apr 11, 2011 at 03:01:32PM -0500, Andrei Warkentin wrote:
>> Missing include for <asm/delay.h>
>>
>> Signed-off-by: Andrei Warkentin <andreiw@xxxxxxxxxxxx>
>> ---
>>  drivers/staging/hv/hv_mouse.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
>> index 50147f8..c5020c0 100644
>> --- a/drivers/staging/hv/hv_mouse.c
>> +++ b/drivers/staging/hv/hv_mouse.c
>> @@ -23,6 +23,7 @@
>>  #include <linux/hiddev.h>
>>  #include <linux/pci.h>
>>  #include <linux/dmi.h>
>> +#include <asm/delay.h>
>
> Never include "<asm/" include files if at all possible.
>

Oops, alright, will do.

> Anyway, this should already be fixed in Linus's tree, right?
>

Sorry no clue, if so, thanks ahead. I was testing something else in
SD/MMC-land and wanted to make sure it compiled cleanly on x86/x64.

A
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/