Re: [RFC/PATCH v3 2/5] uas: MS UAS Gadget driver - Infrastructure

From: Greg KH
Date: Thu Apr 14 2011 - 13:41:37 EST


On Thu, Apr 14, 2011 at 04:36:15PM +0300, Tatyana Brokhman wrote:
> --- /dev/null
> +++ b/drivers/usb/gadget/f_uasp.c
> @@ -0,0 +1,2399 @@
> +/*
> + * f_uasp.c -- Mass Storage USB UASP Composite Function
> + *
> + * Copyright (C) 2003-2005 Alan Stern
> + * Copyright (C) 2011 Code Aurora Forum.
> + * All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> + * 02110-1301, USA.

Minor nit. Never include this last paragraph in your code unless you
guarantee you are willing to keep up with the office moves of the FSF
for the next 40+ years and promise to update this file as well.

It's pointless and has nothing to do with kernel development stuff, just
leave it out please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/