Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins

From: Alan Cox
Date: Tue Apr 19 2011 - 17:19:57 EST


> > I.e. PCI driver can now map the whole area with a single ioremap(),
> > and then call bgpio_probe(), which will provide accessors and
> > common MMIO GPIO registration stuff.
>
> Looks sane and providing its all using iomap/ioread/iowrite it covers all
> cases nicely.

Actually not using iomap makes more sense on second thoughts, not all
platforms have a generic iomap implementation.

So yes this all looks good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/