Re: [PATCH 3/4] Intel PTI implementaiton of MIPI 1149.7.

[David Rientjes]

On Tue, 19 Apr 2011, james_p_freyensee@xxxxxxxxxxxxxxx wrote:

> +static void pti_control_frame_built_and_sent(struct pti_masterchannel *mc)
> +{
> +	struct pti_masterchannel mccontrol = {.master = CONTROL_ID,
> +					      .channel = 0};
> +	const char *control_format = "%3d %3d %s";
> +
> +	char comm[sizeof(current->comm) + 1];
> +	u8 control_frame[CONTROL_FRAME_LEN];
> +
> +	if (!in_interrupt())
> +		get_task_comm(comm, current);
> +	else
> +		strcpy(comm, "Interrupt");
> +
> +	/* Ensure our buffer is zero terminated */
> +	comm[sizeof(current->comm)] = 0;
> +

You definitely need to use get_task_comm() here, but that means you can't 
allocate char comm[] on the stack with anything but TASK_COMM_LEN, which 
is small enough that it shouldn't be an issue.  Otherwise there's nothing 
protecting sizeof(current->comm) from changing without holding 
task_lock(current).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/