Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues

From: Nicolas Kaiser
Date: Thu Apr 21 2011 - 04:32:39 EST


* Karthigan Srinivasan <karthigan.srinivasan@xxxxxx>:
> Fixed brace and comment coding style issues in code.
>
> Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@xxxxxx>
> ---
> drivers/acpi/utils.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index b002a47..2cf81a1 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -99,9 +99,9 @@ acpi_extract_package(union acpi_object *package,
>
> union acpi_object *element = &(package->package.elements[i]);
>
> - if (!element) {
> + if (!element)
^
You are introducing trailing whitespace.

> return AE_BAD_DATA;
> - }
> +
^^^^^^^^^^^^^
For every pair of braces you clean away, you're adding
two new coding style issues.

Best regards,
Nicolas Kaiser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/