Re: [PATCH 13/14] regulator: max8925: fix not add device ifmissing init data

From: Mark Brown
Date: Thu Apr 21 2011 - 14:32:42 EST


On Thu, Apr 21, 2011 at 11:23:19PM +0800, Haojian Zhuang wrote:
> On Thu, Apr 21, 2011 at 8:03 PM, Mark Brown

> > What makes you say this?  If you remove the check for the first entry
> > being null then the driver will go and register all the regulators which
> > seems fine.  That seems like it fixes the problem with skipping all the
> > regulators if the first one has no platform data.

> If I keep original method and only fix the null issue on regulator[0], I can
> also register regulators. But it'll display error messages since
> regulator_init_data is null while it's registers.

Registering regulators with null init data seems like a reasonable thing
to want to do - let's just remove the error message.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/