Re: [PATCH v2 4/7] signal: sigprocmask: narrow the scope of->siglock

From: Tejun Heo
Date: Mon Apr 25 2011 - 07:05:45 EST


On Mon, Apr 18, 2011 at 03:45:38PM +0200, Oleg Nesterov wrote:
> No functional changes, preparation to simplify the review of the next change.
>
> 1. We can read current->block lockless, nobody else can ever change this mask.

current->blocked

>
> 2. Calculate the resulting sigset_t outside of ->siglock into the temporary
> variable, then take ->siglock and change ->blocked.
>
> Also, kill the stale comment about BKL.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/