Re: [PATCH] kbuild: allow headerdep to work in KBUILD_OUTPUT and addtargets to PHONY

From: Arnaud Lacombe
Date: Tue Apr 26 2011 - 02:52:59 EST


Hi,

On Sun, Apr 24, 2011 at 4:08 PM, Peter Foley <pefoley2@xxxxxxxxxxx> wrote:
> This patch fixes the headerdep target so it will work when make is executed from KBUILD_OUTPUT.
> It also adds a few targets to PHONY so they are always executed.
>
one change, one patch, please.

Why do you want that much consistency check to be always ran ?
Especially `coccicheck', which rely on a non-common program being
available.

Thanks,
- Arnaud

> Signed-off-by: Peter Foley <pefoley2@xxxxxxxxxxx>
> ---
>  Makefile |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b967b96..093c9d2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -991,7 +991,8 @@ include/generated/utsrelease.h: include/config/kernel.release FORCE
>
>  PHONY += headerdep
>  headerdep:
> -       $(Q)find include/ -name '*.h' | xargs --max-args 1 scripts/headerdep.pl
> +       $(Q)find $(srctree)/include/ -name '*.h' | xargs --max-args 1 \
> +       $(srctree)/scripts/headerdep.pl -I$(srctree)/include
>
>  # ---------------------------------------------------------------------------
>
> @@ -1392,6 +1393,8 @@ tags TAGS cscope gtags: FORCE
>  # Scripts to check various things for consistency
>  # ---------------------------------------------------------------------------
>
> +PHONY += includecheck versioncheck coccicheck namespacecheck export_report
> +
>  includecheck:
>        find * $(RCS_FIND_IGNORE) \
>                -name '*.[hcS]' -type f -print | sort \
> --
> 1.7.5.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/