Re: [PATCH 2/3] signal: introduce do_sigtimedwait() to factor outcompat/native code

From: Matt Fleming
Date: Tue Apr 26 2011 - 06:28:12 EST


On Sat, 23 Apr 2011 19:59:40 +0200
Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> Factor out the common code in sys_rt_sigtimedwait/compat_sys_rt_sigtimedwait
> to the new helper, do_sigtimedwait().
>
> Perhaps it would be better to move compat_sys_rt_sigtimedwait() into
> signal.c under CONFIG_COMPAT, then we can make do_sigtimedwait() static.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Reviewed-by: Matt Fleming <matt.fleming@xxxxxxxxxxxxxxx>

The changes Tejun suggested seem like a good idea. I also think that
moving compat_sys_rt_sigtimedwait() into signal.c makes sense.

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/