Re: [PATCHv4 1/4] MFD: TPS65910: Add new mfd device for TPS65910

[Samuel Ortiz]

Hi Jorge,

On Thu, Apr 21, 2011 at 09:35:43AM -0500, Jorge Eduardo Candelaria wrote:
> From: Graeme Gregory <gg@xxxxxxxxxxxxxxx>
> 
> The TPS65910 chip is a power management IC for multimedia and handheld
> devices. It contains the following components:
The patch looks mostly good to me.
You may want to add a locked tps65910_set|clear_bits() API, since it seems
you're doing many read(reg), write(reg) sequences in the GPIO driver. That
could also be directly used by the regulator one.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/