RE: [PATCH V4] POWER: perf_event: Skip updating kernel counters if register value shrinks

From: David Laight
Date: Wed Apr 27 2011 - 09:05:25 EST



> On Wed, 27 Apr 2011, David Laight wrote:
>
> > > But it isn't, and it doesn't have trouble with 2^32 - 1.
> >
> > what about:
> > prev = 0x00000001
> > val = 0xffffffff
>
> Result is 0xfffffffe and we are fine.

'delta' will be 0xfffffffe, but you need the function to
return zero - since the underlying counter has decremented
by 2. But 'prev > val' is false so the counter will
be increased by 2^32-2.

David


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/