Re: [PATCH] [96/106] iwlagn: Support new 5000 microcode.

[Tim Gardner]

On 04/26/2011 03:14 PM, Andi Kleen wrote:
> 2.6.35-longterm review patch.  If anyone has any objections, please let me know.
>
> ------------------
> From: Fry, Donald H<donald.h.fry@xxxxxxxxx>
>
> commit 41504cce240f791f1e16561db95728c5537fbad9 upstream.
>
> New iwlwifi-5000 microcode requires driver support for API version 5.
>
> Signed-off-by: Don Fry<donald.h.fry@xxxxxxxxx>
> Signed-off-by: Wey-Yi Guy<wey-yi.w.guy@xxxxxxxxx>
> Signed-off-by: Stanislaw Gruszka<sgruszka@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman<gregkh@xxxxxxx>
> Signed-off-by: Andi Kleen<ak@xxxxxxxxxxxxxxx>
>
> ---
>   drivers/net/wireless/iwlwifi/iwl-5000.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.35.y/drivers/net/wireless/iwlwifi/iwl-5000.c
> ===================================================================
> --- linux-2.6.35.y.orig/drivers/net/wireless/iwlwifi/iwl-5000.c
> +++ linux-2.6.35.y/drivers/net/wireless/iwlwifi/iwl-5000.c
> @@ -51,7 +51,7 @@
>   #include "iwl-agn-debugfs.h"
>
>   /* Highest firmware API version supported */
> -#define IWL5000_UCODE_API_MAX 2
> +#define IWL5000_UCODE_API_MAX 5
>   #define IWL5150_UCODE_API_MAX 2
>
>   /* Lowest firmware API version supported */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Wey-yi,

Will this cause any issues with the existing 2.6.35.12 iwl-5000 driver? 
Is the version 5 API backwards compatible? Ubuntu installs 
iwlwifi-5000-5.ucode by default in order to support compat-wireless 
backports from 2.6.3[678], so I'd hate to break those folks that are 
using the stock 2.6.35.y driver.

rtg
--
Tim Gardner tim.gardner@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/