Re: [PATCH] Staging: Westbridge: replace custom debug macros withpr_...() macros

From: Greg KH
Date: Thu Apr 28 2011 - 15:53:15 EST


On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote:
> >From Sutharsan Ramamoorthy <srmt@xxxxxxxxxxx>
>
> This patch replaces custom debug macros with Linux kernel's pr_...() macros.

Why not use the dev_dbg() and other macros instead of these? You do
have access to a struct device for all of these places in the code,
right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/