Re: [PATCH 2/2] dmaengine: shdma: add runtime- and system-levelpower management

[Koul, Vinod]

On Mon, 2011-05-02 at 11:04 +0200, Guennadi Liakhovetski wrote:
> On Mon, 2 May 2011, Koul, Vinod wrote:
> 
> > On Fri, 2011-04-29 at 19:09 +0200, Guennadi Liakhovetski wrote:
> > > This patch extends and fixes runtime power management in the shdma
> > > driver to support powering down the DMA controller and adds support
> > > for system-level suspend and resume.
> > > 
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> > > ---
> > >  drivers/dma/shdma.c |   68 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  drivers/dma/shdma.h |    1 +
> > >  2 files changed, 69 insertions(+), 0 deletions(-)
> > > 
> > 
> > >  
> > > +static int sh_dmae_runtime_suspend(struct device *dev)
> > > +{
> > > +	return 0;
> > > +}
> > Don't you need to initialize you device on resume...????
> 
> Hm, yes, but this is suspend... Resume is below. Sorry, I probably don't 
> understand your question.
Opps, my question was for empty suspend. Dont you need to power off you
device.
> 
> > > +
> > > +static int sh_dmae_runtime_resume(struct device *dev)
> > > +{
> > > +	struct sh_dmae_device *shdev = dev_get_drvdata(dev);
> > > +
> > > +	return sh_dmae_rst(shdev);
> > > +}
> > > +
> > > +#ifdef CONFIG_PM
> > This should be removed...
> 
> You mean, these functions just won't be called, but this way we save a 
> couple of bytes if PM is not set, don't we?
I meant you dont need to have this, PM is usually part of core options
which ppl enable nowadays. Do you run with PM disabled?


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/