Re: mmotm 2011-04-29-16-25 uploaded

From: Randy Dunlap
Date: Mon May 02 2011 - 11:46:39 EST


On Sun, 1 May 2011 16:47:43 +0900 (JST) KOSAKI Motohiro wrote:

> > On Fri, 29 Apr 2011 16:26:16 -0700 akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> >
> > > The mm-of-the-moment snapshot 2011-04-29-16-25 has been uploaded to
> > >
> > > http://userweb.kernel.org/~akpm/mmotm/
> > >
> > > and will soon be available at
> > >
> > > git://zen-kernel.org/kernel/mmotm.git
> > >
> > > It contains the following patches against 2.6.39-rc5:
> >
> >
> > mm-per-node-vmstat-show-proper-vmstats.patch
> >
> > when CONFIG_PROC_FS is not enabled:
> >
> > drivers/built-in.o: In function `node_read_vmstat':
> > node.c:(.text+0x1e995): undefined reference to `vmstat_text'
> >
> > from drivers/base/node.c
>
>
> Thank you for finding that!
>
>
>
> From 63ad7c06f082f8423c033b9f54070e14d561db7e Mon Sep 17 00:00:00 2001
> From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> Date: Sun, 1 May 2011 16:00:09 +0900
> Subject: [PATCH] vmstat: fix build error when SYSFS=y and PROC_FS=n
>
> Randy Dunlap pointed out node.c makes build error when
> PROC_FS=n. Because node.c#node_read_vmstat() uses vmstat_text
> and it depend on PROC_FS.
>
> Thus, this patch change it to depend both SYSFS and PROC_FS.
>
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

Thanks.

> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> ---
> mm/vmstat.c | 261 ++++++++++++++++++++++++++++++-----------------------------
> 1 files changed, 132 insertions(+), 129 deletions(-)


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/