Re: [PATCH 3/4] x86, mce: Add persistent MCE event

[Joe Perches]

On Tue, 2011-05-03 at 09:18 +0200, Borislav Petkov wrote:
> On Tue, May 03, 2011 at 02:44:01AM -0400, Ingo Molnar wrote:
> > * Borislav Petkov <bp@xxxxxxxxx> wrote:
[]
> > > +static struct dentry *mce_add_event_debugfs(struct perf_event *event, int cpu)
> > > +{
> > > +	char buf[14];
> > > +
> > > +	sprintf(buf, "mce_record%d", cpu);

trivia:

buf[14] doesn't fit 10k+ cpus.
Isn't that an unnecessary future/current problem?
Maybe something bigger?
	char buf[sizeof("mce_record") + sizeof(int) * 3] 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/