Re: [patch v2 3/3] SATA: enable non-queueable flush flag

From: Tejun Heo
Date: Wed May 04 2011 - 04:53:33 EST


On Wed, May 04, 2011 at 04:17:28PM +0800, shaohua.li@xxxxxxxxx wrote:
> Enable non-queueable flush flag for SATA.
>
> Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>
> ---
> drivers/ata/libata-scsi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux/drivers/ata/libata-scsi.c
> ===================================================================
> --- linux.orig/drivers/ata/libata-scsi.c 2011-05-04 14:20:41.000000000 +0800
> +++ linux/drivers/ata/libata-scsi.c 2011-05-04 14:28:28.000000000 +0800
> @@ -3424,7 +3424,9 @@ void ata_scsi_scan_host(struct ata_port
> sdev = __scsi_add_device(ap->scsi_host, channel, id, 0,
> NULL);
> if (!IS_ERR(sdev)) {
> + struct request_queue *q = sdev->request_queue;
> dev->sdev = sdev;
> + blk_set_queue_flush_queueable(q, false);
> scsi_device_put(sdev);
> } else {
> dev->sdev = NULL;

Isn't ata_scsi_dev_config() better place for this?

Thakns.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/