Re: [PATCHv3 0/7] gpio: extend basic_mmio_gpio for differentcontrollers

From: Jamie Iles
Date: Wed May 04 2011 - 11:04:48 EST


On Wed, May 04, 2011 at 07:02:34PM +0400, Anton Vorontsov wrote:
> On Wed, May 04, 2011 at 03:37:57PM +0100, Jamie Iles wrote:
> [...]
> > + err = bgpio_init(bgc, dev, sz, dat, set, clr, dirout, dirin, be);
> > + if (err)
> > + return err;
> > +
> > + if (pdata) {
> > + bgc->gc.base = pdata->base;
> > + if (pdata->ngpio > 0)
> > + bgc->gc.ngpio = pdata->ngpio;
> > + }
> > +
> > + platform_set_drvdata(pdev, bgc);
> > +
> > + return 0;
>
> return gpio_chip_add(&bgc->gc)? Or bgpio_chip_add(bgc);

Yes, this got lost in the move from bgpio_probe() to bgpio_init().
Thanks!

Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/