Re: [PATCH 3/3] mm: change incorrect 'extern' keyword to 'static'

[Yong Zhang]

On Thu, May 5, 2011 at 4:51 PM, Robin Dong <hao.bigrat@xxxxxxxxx> wrote:
> Change function memblock_memory_can_coalesce from 'extern' to 'static' to
> match the memblock_* series function.
>
> Signed-off-by: Robin Dong <sanbai@xxxxxxxxxx>
> ---
> Âmm/memblock.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 400dc62..9570c43 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -292,7 +292,7 @@ static int __init_memblock memblock_double_array(struct memblock_type *type)
> Â Â Â Âreturn 0;
> Â}
>
> -extern int __init_memblock __weak memblock_memory_can_coalesce(phys_addr_t addr1, phys_addr_t size1,
> +static int __init_memblock __weak memblock_memory_can_coalesce(phys_addr_t addr1, phys_addr_t size1,

I guess you will get build error as
"error: static declaration of â***â follows non-static declaration".

No?

Thanks,
Yong

> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âphys_addr_t addr2, phys_addr_t size2)
> Â{
> Â Â Â Âreturn 1;
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/