Re: PATCH] mm: Use alloc_bootmem_node_nopanic on really needed path

[Ingo Molnar]

* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> On 05/06/2011 03:39 PM, Andrew Morton wrote:
> > On Fri, 06 May 2011 15:29:41 -0700
> > Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> > 
> >> Stefan found nobootmem does not work on his system that only have 8M ram.
> > 
> > What does "does not work" mean?  From the patch, it appears that the
> > machine paniced?
> 
> yes, early panic.

Why the heck did you not share this information in the original changelog 
itself? Do you think maintainers enjoy having to waste time asking you again 
and again to clarify your changelogs?

Changelogs need specificity. "does not work" is 10 times worse than "we saw an 
early crash" or "the system booted up with only 10% of the physical RAM 
visible". There are many degrees of "does not work".

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/