Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver

From: Hauke Mehrtens
Date: Sun May 08 2011 - 08:48:36 EST


On 05/05/2011 11:59 PM, RafaÅ MiÅecki wrote:
.....
> --- /dev/null
> +++ b/drivers/bcma/bcma_private.h
.....
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
......
> --- /dev/null
> +++ b/drivers/bcma/scan.h
> @@ -0,0 +1,56 @@
> +#ifndef BCMA_SCAN_H_
> +#define BCMA_SCAN_H_
> +
> +#define BCMA_ADDR_BASE 0x18000000
> +#define BCMA_WRAP_BASE 0x18100000
> +
.....

While graping through the code I found this. BCMA_ADDR_BASE and
BCMA_WRAP_BASE are defined twice.

Why are some constants defined in purpose specific headers in
drivers/bcma/*.h like drivers/bcma/scan.h and some in
drivers/bcma/bcma_private.h and other in include/linux/bcma/bcma_regs.h ?

Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/