Re: [PATCH] RCU: remove alignment padding from rcu_data on 64 bitbuilds

[Paul E. McKenney]

On Fri, May 06, 2011 at 01:13:56PM +0100, Richard Kennedy wrote:
> On Fri, 2011-05-06 at 08:20 +0200, Eric Dumazet wrote:
> ...
> > We could shrink this structure more, converting some 64bit fields to
> > 32bit ones.
> > 
> > Rationale is the algo is working well on 32bit arches, no need to use
> > 64bit fields.
> > 
> > candidates : completed, gpnum, passed_quiesc_completed, qlen,
> > qlen_last_fqs_check, blimit.
> > 
> > Counters might be converted too.
> 
> I don't know the code well enough to make that decision ;)
> Is it possible to shrink it enough to free up another cache line ?
> (16 longs to ints).

A number of these could be changed from long to int, though appropriate
adjustments need to be made.  Some of the fields could be placed under
#ifdef CONFIG_RCU_TRACE, though again, corresponding adjustments would
need to be made.

> CONFIG_NO_HZ adds 24 bytes so even for users with !CONFIG_NO_HZ the
> variables you suggest are not enough to free a cache line.  

Yep.  And recent work introducing RCU priority boosting adds some more.

But it is not like this structure is allocated as a unit, so are you
really all that sensitive to the exact size?

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/