Re: [PATCH V2 2/5] pch_dma: modify for checkpatch

From: Joe Perches
Date: Mon May 09 2011 - 00:02:15 EST


On Mon, 2011-05-09 at 12:40 +0900, Tomoya MORINAGA wrote:
> Fix checkpatch warnings.
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@xxxxxxxxxxxxxxx>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
[]
> @@ -138,7 +138,8 @@ struct pch_dma {
> -static inline struct pch_dma_desc *to_pd_desc(struct dma_async_tx_descriptor *txd)
> +static inline struct pch_dma_desc *to_pd_desc(
> + struct dma_async_tx_descriptor *txd)

I think these are better either not changed at all
or to either of the styles below:

static inline struct pch_dma_desc *
to_pd_desc(struct dma_async_tx_descriptor *txd)

static inline
struct pch_dma_desc *to_pd_desc(struct dma_async_tx_descriptor *txd)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/