Re: [PATCH V4 3/5] dmaengine/dw_dmac: Divide one sg to many desc,if sg len is greater than DWC_MAX_COUNT

From: Koul, Vinod
Date: Mon May 09 2011 - 02:43:35 EST


On Mon, 2011-05-09 at 12:03 +0530, viresh kumar wrote:
> On 05/09/2011 11:17 AM, Koul, Vinod wrote:
> > Ah, then there is another todo for this driver. Move from chan->private
> > to DMA_SLAVE_CONFIG.
> >
> > struct dma_slave_config has dedicated fields for both source and
> > destination widths, src_addr_width & dst_addr_width please use them...
> > You should pass this structure to device control API as:
> > dmaengine_device_control(
> > chan, DMA_SLAVE_CONFIG, (unsigned long)&slave_config);
>
> As soon as i get some time, will study & implement this.
> For now, please push this patchset (if it looks fine).
>
rest looks OK. Please fix the patch1.


--
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/