Re: [PATCH net-next 0/4] tulip: logging cleanups

From: David Miller
Date: Mon May 09 2011 - 14:47:42 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Fri, 6 May 2011 19:08:41 -0700

> Joe Perches (4):
> tulip: xircom_cb: Convert #ifdef DEBUG blocks and enter/leave uses
> tulip: Convert printks to netdev_<level>
> tulip: Convert uses of KERN_DEBUG
> tulip: Use pr_<level> where appropriate

With the advent of the function tracer, those silly function entry/exit
logging things are entirely superfluous.

They make the code look ugly too.

So you have my approval to just kill those things off entirely.

Please do that and respin this patch set, thanks Joe!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/