RE: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:greg@xxxxxxxxx]
> Sent: Monday, May 09, 2011 6:53 PM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang;
> Abhishek Kane (Mindtree Consulting PVT LTD); Hank Janssen
> Subject: Re: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()
> 
> On Mon, May 09, 2011 at 02:55:59PM -0700, K. Y. Srinivasan wrote:
> > cleanup() is an empty function; get rid of it.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > Signed-off-by: Abhishek Kane <v-abkane@xxxxxxxxxxxxx>
> > Signed-off-by: Hank Janssen <hjanssen@xxxxxxxxxxxxx>
> > ---
> >  drivers/staging/hv/netvsc_drv.c |    4 ----
> 
> Just picking a random patch out of this series (which, I only received
> the first 132, not all 206).
> 
> You need to specify a better changelog entry as you didn't say what code
> you are changing in the Subject:.
> 
> How about:
> 	Staging: hv: netvsc_drv: Get rid of call to cleanup()
> 
> Otherwise I would think (and I did) that you got rid of a global
> function called cleanup() in all of the hv code.
> 
> Care to fix the names of your patches?

Good point; I will fix up the names.
> 
> Note, I wouldn't recommend sending that many patches to lkml, it's not
> needed, just stick to the devel@xxxxxxxxxxxxxxxxxxxxxx list as I really
> doubt anyone else cares about this code at the moment.

Agreed; I will do that. Shall I go ahead and fix the names and send the patches 
just to you or do you want me to send them to the devel list as well.

Regards,

K. Y
> 
> thanks,
> 
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/