Re: [patch 02/15] sched: hierarchical task accounting for SCHED_OTHER

From: Hidetoshi Seto
Date: Tue May 10 2011 - 03:18:18 EST


Some typos in the description.

(2011/05/03 18:28), Paul Turner wrote:
> Introduce hierarchal task accounting for the group scheduling case in CFS, as

hierarchical

> well as promoting the responsibility for maintaining rq->nr_running to the
> scheduling classes.
>
> The primary motivation for this is that with scheduling classes supporting
> bandwidht throttling it is possible for entities participating in trottled

bandwidth throttled

> sub-trees to not have root visible changes in rq->nr_running across activate
> and de-activate operations. This in turn leads to incorrect idle and
> weight-per-task load balance decisions.
>
> This also allows us to make a small fixlet to the fastpath in pick_next_task()
> under group scheduling.
>
> Note: this issue also exists with the existing sched_rt throttling mechanism.
> This patch does not address that.
>
> Signed-off-by: Paul Turner <pjt@xxxxxxxxxx>
>
> ---

The patch is good.

Reviewed-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/