Re: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy_hcd

From: Sergei Shtylyov
Date: Tue May 10 2011 - 07:27:05 EST


Hello.

On 09-05-2011 21:49, Sebastian Andrzej Siewior wrote:

+
+ retval = usb_add_hcd(hs_hcd, 0, IRQF_DISABLED | IRQF_SHARED);

Why IRQF_DISABLED | IRQF_SHARED? you don't interrupts at all.

Moreover, IRQF_DISABLED is a nop now, see <linux/interrupt.h>.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/