Re: [PATCH] dmaengine: at_hdmac: pause: no need to wait for FIFOempty

From: Sergei Shtylyov
Date: Tue May 10 2011 - 07:58:01 EST


Hello.

On 09-05-2011 20:11, Nicolas Ferre wrote:

The addition of the pause feature to atc_control an active wait was introduced
to check the FIFO empty event.

Couldn't parse this -- did you forget "with"at the start of the statement?

This event was not always happening and
a timout contition was needed.
But, in some cases, this event depend on the peripheral connected to the
channel that is paused: FIFO becomes empty if the peripheral consumes data.
The timeout is pretty difficult to evaluate. Moreover, this check is not
needed.
In conclusion, it seems sensible to entirely remove the checking of
"FIFO empty" status when pausing.

Signed-off-by: Nicolas Ferre<nicolas.ferre@xxxxxxxxx>

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/