Re: [PATCH 2/4] pinmux: add a driver for the U300 pinmux

From: Joe Perches
Date: Tue May 10 2011 - 20:28:56 EST


On Wed, 2011-05-11 at 02:17 +0200, Linus Walleij wrote:
> 2011/5/2 Joe Perches <joe@xxxxxxxxxxx>:
> > On Mon, 2011-05-02 at 21:16 +0200, Linus Walleij wrote:
> > []
> >> diff --git a/drivers/pinmux/pinmux-u300.c b/drivers/pinmux/pinmux-u300.c
> >> +++ b/drivers/pinmux/pinmux-u300.c
> >> +struct u300_pin_desc {
> >> + unsigned number;
> >> + char *name;
> > const char *name?
> Thanks, fixed!
> Can I have your reviewed-by for this patch given I fixed that?

Hi Linus.

I've only looked at the code not compiled, used or tested it
and so I think my sign-off isn't particularly valuable.

But your design and implementation seem sensible.

Anyway if you want for the whole series:

Reviewed-but-not-compiled-used-or-tested-by: Joe Perches <joe@xxxxxxxxxxx>

(that way I won't get copied by get_maintainer.pl ;)

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/