Re: [RFC PATCH] perf: Carve out cgroup-related code

From: Borislav Petkov
Date: Wed May 11 2011 - 12:29:52 EST


On Wed, May 11, 2011 at 09:46:40AM -0400, Peter Zijlstra wrote:
> On Wed, 2011-05-11 at 14:11 +0200, Borislav Petkov wrote:
> > include/linux/perf_event.h | 138 ++++++++++++-
>
> I don't like exposing all that in a kernel wide header.. should we maybe
> have kernel/events/internal.h?

Sounds prudent. Maybe add a patch ontop that moves all perf_event.h
exports which are shared _only_ between kernel/events/*.c compilation
units to an internal.h header? Ingo?

Thanks.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/