Re: [RFC][PATCH] pstore: EFI Support

[H. Peter Anvin]

On 05/11/2011 06:09 AM, AmÃrico Wang wrote:
> On Wed, May 11, 2011 at 12:11 AM, Greg KH<greg@xxxxxxxxx>  wrote:
> > On Tue, May 10, 2011 at 11:00:44AM -0400, Seiji Aguchi wrote:
> > > Description of boot paremeters is following.
> > >
> > >   - efi_pstore_enable
> > >     enable EFI support of pstore.
> > >
> > >   - efi_pstore_len
> > >     Sets the buffer size of EFI variable space used by pstore.
> >
> > Please don't add new boot parameters if at all possible.  Distros will
> > not know to enable them, and users don't know how to either.
> >
> > Use sane defaults, and provide ways to override them if needed, but
> > don't rely on them for new functionality if at all possible.
>
> I agree. It seems that we should enable this by default when APEI and
> EFI are both enabled, this could be done by Kconfig.

No, it can't.  That would be a compile-time option, but the selection 
needs to be at runtime.

However, it is still unclear that this is actually a win at all...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/